Skip to content

Conversation

@kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Sep 16, 2025

Rationale for this change

On Windows, poetry is not automatically put in the PATH
pip also might point to a different executable

Source all commands from the same python

Are these changes tested?

Are there any user-facing changes?

@kevinjqliu kevinjqliu requested a review from Fokko September 16, 2025 17:31
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, I always bump into the same issue when I have a new laptop 👍

@Fokko Fokko merged commit a56795f into apache:main Sep 17, 2025
10 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/improve-makefile branch September 21, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants