Skip to content

Conversation

@geruh
Copy link
Contributor

@geruh geruh commented Sep 19, 2025

related to #2425

Rationale for this change

Removing the user flag from the poetry installation to allow users who want to install poetry into a separate dedicated virtual environment.

This virtual environment must be separate from the environment in which we install the iceberg-python repo.

Are these changes tested?

Yes manual testing

> python3 -m venv ~/.venvs/poetry

> source ~/.venvs/poetry/bin/activate

>  echo $VIRTUAL_ENV
/Users/geru/.venvs/poetry

> python -m pip install -U pip setuptools wheel

> poetry --version
Poetry (version 2.1.4)

> poetry show -v
Using virtualenv: /Users/geru/workspace/iceberg-python/.venv

> poetry install
SUCCESS

Are there any user-facing changes?

no

cc: @kevinjqliu

@jayceslesar
Copy link
Contributor

ah I wonder if this has been the source of my issues, I was just manually created a venv with uv, installing poetry and then running make install-dependencies but I imagine this might fix? It also might mess with CI but I suppose we will find out

@kevinjqliu
Copy link
Contributor

thats a good case to check. @jayceslesar can you double check if this resolved your issue?

@jayceslesar
Copy link
Contributor

thats a good case to check. @jayceslesar can you double check if this resolved your issue?

That worked!

@kevinjqliu kevinjqliu merged commit 6935b41 into apache:main Sep 19, 2025
10 checks passed
@kevinjqliu
Copy link
Contributor

Thanks @geruh and @jayceslesar for verifying :)

@geruh geruh deleted the poetry branch December 27, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants