fix: incorrect descriptions of snapshot operations #2513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
approved these changes
Sep 24, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Oh wow, great catch @zhongyujiang 🙌
Fokko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…unctions.
Rationale for this change
Currently, the documentation of these write functions contains some inaccuracies regarding snapshot operations. These update methods do not actually produce
replacesnapshots, but ratheroverwritesnapshots, because the rewrite here modifies the data (dropping the records that match the overwrite filter).A
replacesnapshot is only generated when the table data itself is not changed, such as during data file rewrites or manifest rewrites.https://iceberg.apache.org/spec/#snapshots
Are these changes tested?
Are there any user-facing changes?