Make true/false expression JSON serializable #2537
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Sep 29, 2025
Comment on lines
+123
to
+144
| def test_serialize_partition_spec_trye() -> None: | ||
| partitioned = PartitionSpec( | ||
| PartitionField(source_id=1, field_id=1000, transform=TruncateTransform(width=19), name="str_truncate"), | ||
| PartitionField(source_id=2, field_id=1001, transform=BucketTransform(num_buckets=25), name="int_bucket"), | ||
| spec_id=3, | ||
| ) | ||
| assert ( | ||
| partitioned.model_dump_json() | ||
| == """{"spec-id":3,"fields":[{"source-id":1,"field-id":1000,"transform":"truncate[19]","name":"str_truncate"},{"source-id":2,"field-id":1001,"transform":"bucket[25]","name":"int_bucket"}]}""" | ||
| ) | ||
|
|
||
| def test_serialize_partition_spec() -> None: | ||
| partitioned = PartitionSpec( | ||
| PartitionField(source_id=1, field_id=1000, transform=TruncateTransform(width=19), name="str_truncate"), | ||
| PartitionField(source_id=2, field_id=1001, transform=BucketTransform(num_buckets=25), name="int_bucket"), | ||
| spec_id=3, | ||
| ) | ||
| assert ( | ||
| partitioned.model_dump_json() | ||
| == """{"spec-id":3,"fields":[{"source-id":1,"field-id":1000,"transform":"truncate[19]","name":"str_truncate"},{"source-id":2,"field-id":1001,"transform":"bucket[25]","name":"int_bucket"}]}""" | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
I think these are copy-paste:
Suggested change
| def test_serialize_partition_spec_trye() -> None: | |
| partitioned = PartitionSpec( | |
| PartitionField(source_id=1, field_id=1000, transform=TruncateTransform(width=19), name="str_truncate"), | |
| PartitionField(source_id=2, field_id=1001, transform=BucketTransform(num_buckets=25), name="int_bucket"), | |
| spec_id=3, | |
| ) | |
| assert ( | |
| partitioned.model_dump_json() | |
| == """{"spec-id":3,"fields":[{"source-id":1,"field-id":1000,"transform":"truncate[19]","name":"str_truncate"},{"source-id":2,"field-id":1001,"transform":"bucket[25]","name":"int_bucket"}]}""" | |
| ) | |
| def test_serialize_partition_spec() -> None: | |
| partitioned = PartitionSpec( | |
| PartitionField(source_id=1, field_id=1000, transform=TruncateTransform(width=19), name="str_truncate"), | |
| PartitionField(source_id=2, field_id=1001, transform=BucketTransform(num_buckets=25), name="int_bucket"), | |
| spec_id=3, | |
| ) | |
| assert ( | |
| partitioned.model_dump_json() | |
| == """{"spec-id":3,"fields":[{"source-id":1,"field-id":1000,"transform":"truncate[19]","name":"str_truncate"},{"source-id":2,"field-id":1001,"transform":"bucket[25]","name":"int_bucket"}]}""" | |
| ) |
Fokko
reviewed
Sep 29, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
This is going in the right direction, left some comments 👍
Comment on lines
+115
to
+121
| def test_always_true_serializes_to_json_true(): | ||
| expr = AlwaysTrue() | ||
| assert expr.model_dump_json() == "true" | ||
|
|
||
| def test_always_false_serializes_to_json_false(): | ||
| expr = AlwaysFalse() | ||
| assert expr.model_dump_json() == "false" |
Contributor
There was a problem hiding this comment.
Can we move these tests to tests/expressions/text_expressions.py?
Contributor
|
Thanks for working on this @Anubhav007. I'm going to close this since it has been resolved in #2538 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed JSON serialization of True/False expression