Support arbitrary literal comparisons in BETWEEN operator #2567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maytasm
approved these changes
Oct 3, 2025
Contributor
Author
|
@Fokko @kevinjqliu any thoughts here? |
Contributor
|
Also, thanks for the review @maytasm 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Want to support calling BETWEEN for any valid column types, not just numeric columns. This extends support for filter expressions like
date_col BETWEEN '2025-01-01' AND '2025-01-02'.The
test_invalid_betweentest was removed in favor of letting the type checks happen at evaluation time (when the literals are attempted to be cast to the corresponding column's type for comparison).Are these changes tested?
Yes, tested locally applying filters to tables.
Are there any user-facing changes?
Yes,
BETWEENoperator signature has changed, it nows supports all comparable column types.