Skip to content

Conversation

@qccash
Copy link
Contributor

@qccash qccash commented Oct 13, 2025

Rationale for this change

To fix StaticTable._metadata_location_from_version_hint metadata location format ERROR:

        if content.endswith(".metadata.json"):
            return os.path.join(metadata_location, "metadata", content)
        elif content.isnumeric():
            return os.path.join(metadata_location, "metadata", "v%s.metadata.json").format(content)
        else:
            return os.path.join(metadata_location, "metadata", "%s.metadata.json").format(content)

Closes #2608

Are these changes tested?

Yes.

Added 2 more cases with numeric and non numeric metadata version hints.

Are there any user-facing changes?

No

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix!

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everyone loves f-strings 👍 Thanks @qccash

@Fokko Fokko merged commit da70e10 into apache:main Oct 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StaticTable _metadata_location_from_version_hint metadata_location python string format ERROR

3 participants