Skip to content

Fix after model validator signatures #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 1 commit into from
Oct 19, 2025
Merged

Fix after model validator signatures #2626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions pyiceberg/table/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,8 @@ def cleanup_snapshot_id(cls, data: Dict[str, Any]) -> Dict[str, Any]:
return cleanup_snapshot_id(data)

@model_validator(mode="after")
def construct_refs(cls, data: TableMetadataV1) -> TableMetadataV1:
return construct_refs(data)
def construct_refs(self) -> TableMetadataV1:
return construct_refs(self)

@model_validator(mode="before")
def set_v2_compatible_defaults(cls, data: Dict[str, Any]) -> Dict[str, Any]:
Expand Down Expand Up @@ -492,20 +492,20 @@ def cleanup_snapshot_id(cls, data: Dict[str, Any]) -> Dict[str, Any]:
return cleanup_snapshot_id(data)

@model_validator(mode="after")
def check_schemas(cls, table_metadata: TableMetadata) -> TableMetadata:
return check_schemas(table_metadata)
def check_schemas(self) -> TableMetadata:
return check_schemas(self)

@model_validator(mode="after")
def check_partition_specs(cls, table_metadata: TableMetadata) -> TableMetadata:
return check_partition_specs(table_metadata)
def check_partition_specs(self) -> TableMetadata:
return check_partition_specs(self)

@model_validator(mode="after")
def check_sort_orders(cls, table_metadata: TableMetadata) -> TableMetadata:
return check_sort_orders(table_metadata)
def check_sort_orders(self) -> TableMetadata:
return check_sort_orders(self)

@model_validator(mode="after")
def construct_refs(cls, table_metadata: TableMetadata) -> TableMetadata:
return construct_refs(table_metadata)
def construct_refs(self) -> TableMetadata:
return construct_refs(self)

format_version: Literal[2] = Field(alias="format-version", default=2)
"""An integer version number for the format. Implementations must throw
Expand Down Expand Up @@ -536,20 +536,20 @@ def cleanup_snapshot_id(cls, data: Dict[str, Any]) -> Dict[str, Any]:
return cleanup_snapshot_id(data)

@model_validator(mode="after")
def check_schemas(cls, table_metadata: TableMetadata) -> TableMetadata:
return check_schemas(table_metadata)
def check_schemas(self) -> TableMetadata:
return check_schemas(self)

@model_validator(mode="after")
def check_partition_specs(cls, table_metadata: TableMetadata) -> TableMetadata:
return check_partition_specs(table_metadata)
def check_partition_specs(self) -> TableMetadata:
return check_partition_specs(self)

@model_validator(mode="after")
def check_sort_orders(cls, table_metadata: TableMetadata) -> TableMetadata:
return check_sort_orders(table_metadata)
def check_sort_orders(self) -> TableMetadata:
return check_sort_orders(self)

@model_validator(mode="after")
def construct_refs(cls, table_metadata: TableMetadata) -> TableMetadata:
return construct_refs(table_metadata)
def construct_refs(self) -> TableMetadata:
return construct_refs(self)

format_version: Literal[3] = Field(alias="format-version", default=3)
"""An integer version number for the format. Implementations must throw
Expand Down