Add support for v3 snapshot metadata fields #2631
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks so much for adding this! I've actually got #2129 that handles that same functionality. |
Fokko
reviewed
Oct 21, 2025
Comment on lines
+260
to
+262
| @field_validator("first_row_id") | ||
| @classmethod | ||
| def validate_first_row_id(cls, v: Optional[int]) -> Optional[int]: |
Contributor
There was a problem hiding this comment.
Pydantic also allows for annotating with PositiveInt which will do these checks internally: https://docs.pydantic.dev/2.3/api/types/#pydantic.types.PositiveInt
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR Adds
first-row-idandadded-rowsfields to theSnapshotclass to align with Java Iceberg's v3 table format. I know we are very limited with support in Pyiceberg but recently I've been testing out the v3 tables created in java and python is a good way to inspect the changes.Are these changes tested?
yes added some unit test
Are there any user-facing changes?
additions to see some of the snapshot data from v3 tables