feat: replace ExpressionA with IsNull("a") and ExpressionB with IsNul… #2651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
approved these changes
Oct 22, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
LGTM
@jaimeferj Can you pull in main to fix the CI?
jaimeferj
force-pushed
the
feat/remove-expressiona-expressionb-from-tests
branch
from
29aad8f to
70dd72b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2637
Rationale for this change
Are these changes tested?
Yes, tests and lint passing
Are there any user-facing changes?