-
Notifications
You must be signed in to change notification settings - Fork 412
chore: add pyarrow-stubs dependency for type hint & suggestion #2768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the pyarrow-stubs package as a development dependency to provide type hints and IDE suggestions for PyArrow, improving the development experience without affecting the runtime package.
- Added
pyarrow-stubs>=20.0.0.20251107to the dev dependency group - Updated the lock file to include the new dependency and its transitive dependencies
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Added pyarrow-stubs to the dev dependency group for improved type hints during development |
| uv.lock | Updated lock file with pyarrow-stubs package metadata and dependency resolution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable to me, we have more of them already. I'm a bit disappointed that mypy is silent, and we didn't voilated any annotations :D Thanks @dingo4dev for working on this 🙌
kevinjqliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Should we also look to add this in the precommit configs?
iceberg-python/.pre-commit-config.yaml
Lines 35 to 45 in 93a4173
| - repo: https://github.com/pre-commit/mirrors-mypy | |
| rev: v1.18.2 | |
| hooks: | |
| - id: mypy | |
| args: | |
| [--config=pyproject.toml] | |
| additional_dependencies: | |
| - types-cachetools | |
| - types-pytest-lazy-fixture | |
| - types-pytz | |
| - types-requests |
|
Hi all! As of |
|
@rok Thanks for the heads up. This is great news from arrow community! As |
b788b1a to
790e0ef
Compare
@kevinjqliu I added and tried this, I found it not compactible with mypy though. |
|
Thanks for working on this @dingo4dev. Let's move this forward until pyarrow comes with typing. Thanks @rok for letting us know, we're very much looking forward to that 👍 |
Rationale for this change
This PR adds
pyarrow-stubsto the project's development dependencies which provide suggestions and parameter hints, speeding up development.Are these changes tested?
Tested the type hint
Are there any user-facing changes?
No. This is strictly a development dependency and does not affect the runtime package distributed to users.