fix: Remove unused fields from FileScanTask #2777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geruh
changed the title
kevinjqliu
approved these changes
Nov 21, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM these aren't used at all
Contributor
|
cc @Fokko for another pair of eyes 😄 |
Fokko
approved these changes
Nov 21, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
This changes the public API, but I think we can remove this.
The idea was to scale on a row-group level, rather than a file level. But for PyIceberg, I don't think that makes a lot of sense. I'm fine with simplifying this 👍
Contributor
|
Thanks @geruh for picking this up, and thanks @kevinjqliu for working on this 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2776
Rationale for this change
This PR removes the unused
startandlengthfields from theFileScanTask. While working on the models for rest scanning in #2775 we noticed that these fields were initialized but never accessed or used anywhere in the code base.Are these changes tested?
Are there any user-facing changes?
no