Skip to content

fix: Serialize AlwaysTrue/AlwaysFalse as boolean literals #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 1 commit into from
Nov 25, 2025
Merged

fix: Serialize AlwaysTrue/AlwaysFalse as boolean literals #2780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pyiceberg/expressions/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,10 +370,10 @@ def __getnewargs__(self) -> tuple[BooleanExpression]:
return (self.child,)


class AlwaysTrue(BooleanExpression, Singleton, IcebergRootModel[str]):
class AlwaysTrue(BooleanExpression, Singleton, IcebergRootModel[bool]):
"""TRUE expression."""

root: str = "true"
root: bool = True

def __invert__(self) -> AlwaysFalse:
"""Transform the Expression into its negated version."""
Expand All @@ -388,10 +388,10 @@ def __repr__(self) -> str:
return "AlwaysTrue()"


class AlwaysFalse(BooleanExpression, Singleton, IcebergRootModel[str]):
class AlwaysFalse(BooleanExpression, Singleton, IcebergRootModel[bool]):
"""FALSE expression."""

root: str = "false"
root: bool = False

def __invert__(self) -> AlwaysTrue:
"""Transform the Expression into its negated version."""
Expand Down
4 changes: 2 additions & 2 deletions tests/expressions/test_expressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,7 @@ def test_not_json_serialization_and_deserialization() -> None:

def test_always_true() -> None:
always_true = AlwaysTrue()
assert always_true.model_dump_json() == '"true"'
assert always_true.model_dump_json() == "true"
assert str(always_true) == "AlwaysTrue()"
assert repr(always_true) == "AlwaysTrue()"
assert always_true == eval(repr(always_true))
Expand All @@ -779,7 +779,7 @@ def test_always_true() -> None:

def test_always_false() -> None:
always_false = AlwaysFalse()
assert always_false.model_dump_json() == '"false"'
assert always_false.model_dump_json() == "false"
assert str(always_false) == "AlwaysFalse()"
assert repr(always_false) == "AlwaysFalse()"
assert always_false == eval(repr(always_false))
Expand Down