fix ssl deactivation from catalog properties #2985#3012
Open
MenelikV wants to merge 3 commits intoapache:mainfrom
Open
fix ssl deactivation from catalog properties #2985#3012MenelikV wants to merge 3 commits intoapache:mainfrom
MenelikV wants to merge 3 commits intoapache:mainfrom
Conversation
geruh
reviewed
Feb 9, 2026
Contributor
geruh
left a comment
geruh
left a comment
There was a problem hiding this comment.
The fix looks correct to me, just have a few comments
tests/catalog/test_rest.py
Outdated
| "cabundle": False, | ||
| } | ||
| } | ||
| with pytest.raises(ValidationError) as _: |
Contributor
There was a problem hiding this comment.
I think we should directly assert that session.verify is False for extra confidence here. Then we could just do something like the following without the callback logic
catalog = RestCatalog("rest", **{
"uri": TEST_URI,
"token": TEST_TOKEN,
"ssl": {"cabundle": False},
})
assert catalog._session.verify is False
Fokko
approved these changes
Feb 15, 2026
Comment on lines
+361
to
362
| if (ssl_ca_bundle := ssl_config.get(CA_BUNDLE)) is not None: | ||
| session.verify = ssl_ca_bundle |
Contributor
There was a problem hiding this comment.
Nit:
Suggested change
| if (ssl_ca_bundle := ssl_config.get(CA_BUNDLE)) is not None: | |
| session.verify = ssl_ca_bundle | |
| if ssl_config.get(CA_BUNDLE) is not None: | |
| session.verify = ssl_config.get[CA_BUNDLE] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2985
Rationale for this change
Are these changes tested?
Yes
Are there any user-facing changes?