Skip to content

Conversation

@liurenjie1024
Copy link
Contributor

@liurenjie1024 liurenjie1024 commented Jul 28, 2025

Which issue does this PR close?

Fix the ci failure in main branch.

What changes are included in this PR?

Use fixed version of apache/iceberg-rest-fixture.

Are these changes tested?

CI

@liurenjie1024 liurenjie1024 marked this pull request as draft July 28, 2025 10:29
@liurenjie1024 liurenjie1024 requested review from Fokko, Xuanwo, kevinjqliu and sungwy and removed request for Fokko July 28, 2025 14:20
@liurenjie1024 liurenjie1024 marked this pull request as ready for review July 28, 2025 14:20
@liurenjie1024 liurenjie1024 changed the title Try to fix ci. fix ci. Jul 28, 2025
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

services:
rest:
image: apache/iceberg-rest-fixture
image: apache/iceberg-rest-fixture:1.9.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is due to the new default behavior for iceberg-rest-fixture

apache/iceberg#13599

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lesson learned is that we should always have a version attached to docker image, otherwise it will cause failure that's difficult to debug.

@kevinjqliu kevinjqliu merged commit b68c2a7 into apache:main Jul 28, 2025
17 checks passed
@liurenjie1024 liurenjie1024 deleted the ray/fix-ci branch July 29, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants