(feat): Add support for timestamp datafusion pushdown #1968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frisbeeman
force-pushed
the
frisbeeman/pushdown-datafusion-timestamp
branch
from
899af98 to
ef5bc75
Compare
s-prosvirnin
approved these changes
Dec 28, 2025
colinmarc
reviewed
Dec 29, 2025
crates/integrations/datafusion/src/physical_plan/expr_to_predicate.rs
Outdated
Show resolved
Hide resolved
frisbeeman
force-pushed
the
frisbeeman/pushdown-datafusion-timestamp
branch
from
ef5bc75 to
6946f31
Compare
Author
|
Waiting for decision about #1569, if it will be merged, I'll decline this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
DataFusion can push down expressions containing timestamp literals, but the current predicate mapping implementation doesn't support them. This PR adds support for timestamp literals with varying precision levels (nanoseconds from SQL engine, configurable precision from DataFrame API).
Are these changes tested?
Yes, unit tests are included in this PR.