Skip to content

Make IcebergTableProvider::try_new public #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
smaheshwar-pltr wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Make IcebergTableProvider::try_new public #2000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/integrations/datafusion/src/table/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ impl IcebergTableProvider {
///
/// Loads the table once to get the initial schema, then stores the catalog
/// reference for future metadata refreshes on each operation.
pub(crate) async fn try_new(
pub async fn try_new(
Copy link

@pratik0316 pratik0316 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need it to be public?

Copy link
Collaborator

@CTTY CTTY Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I don't think this should be made public. It's more recommended to use IcebergCatalogProvider indirectly register table providers. But would love to hear the use case if any

catalog: Arc<dyn Catalog>,
namespace: NamespaceIdent,
name: impl Into<String>,
Expand Down
Loading