feat(playground): add SQL catalog support#2122
Open
Shekharrajak wants to merge 5 commits intoapache:mainfrom
Open
feat(playground): add SQL catalog support#2122Shekharrajak wants to merge 5 commits intoapache:mainfrom
Shekharrajak wants to merge 5 commits intoapache:mainfrom
Conversation
Contributor
Author
|
We can merge this first #2121 and I will resolve conflicts for this code changes. |
2a8e793 to
1b54f32
Compare
Combines SQL catalog support (from feature branch) with memory catalog support (from upstream main). Both catalog types are now supported: - rest - sql - memory
- Add missing closing delimiters )); and } for unsupported catalog type error - Remove duplicate `use super::*;` statement in tests module
Contributor
Author
|
cc @blackmwk @liurenjie1024 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Added SqlCatalogBuilder
Are these changes tested?
unit tests
and local testing :