feat(datafusion): support isnan predicate pushdown to Iceberg#2142
Open
charlesdong1991 wants to merge 1 commit intoapache:mainfrom
Open
feat(datafusion): support isnan predicate pushdown to Iceberg#2142charlesdong1991 wants to merge 1 commit intoapache:mainfrom
charlesdong1991 wants to merge 1 commit intoapache:mainfrom
Conversation
7f4e475 to
27148c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of the ongoing effort to improve predicate pushdown coverage in the DataFusion integration.
What changes are included in this PR?
This PR adds support for pushing down
isnan()predicates from DataFusion to Iceberg's nativeIsNan/NotNanpredicate operators.In DataFusion,
isnan()is represented as a scalar function (Expr::ScalarFunction) rather than a dedicatedExprvariant (unlikeIsNull/IsNotNull). This PR introduces a newscalar_function_to_iceberg_predicatehelper inexpr_to_predicate.rsthat matches scalar functions by name at runtime and convertsisnan(col)intoPredicate::Unary(IsNan, col).Negation (
NOT isnan(col)) is handled automatically: the existingExpr::Notarm wraps the result inPredicate::Not(...), and Iceberg's downstreamrewrite_notvisitor normalizes it intoPredicate::Unary(NotNan, col).This enables file pruning using
nan_value_countsin manifest metadata for float/double columns, as defined in the Iceberg spec — Manifest Files: field summaries and column statistics.Are these changes tested?
Yes