Skip to content

Conversation

@Caideyipi
Copy link
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@Caideyipi Caideyipi changed the title Optimized the logger when table does not exist in DN heartbeat & Optimized the logger when table does not exist in DN heartbeat && Pipe: Fixed the OPC UA Sink key getter logic && Load: Fixed the missing schema writing for "root" table Jan 22, 2026
@Caideyipi Caideyipi changed the title Optimized the logger when table does not exist in DN heartbeat && Pipe: Fixed the OPC UA Sink key getter logic && Load: Fixed the missing schema writing for "root" table Optimized the logger when table does not exist in DN heartbeat && Pipe: Fixed the OPC UA Sink key getter logic and potentail NPE when closing client && Load: Fixed the missing schema writing for "root" table Jan 22, 2026
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 40.00000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.12%. Comparing base (f198b8e) to head (f6b52a6).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...org/apache/iotdb/db/schemaengine/SchemaEngine.java 0.00% 7 Missing ⚠️
.../pipe/api/customizer/parameter/PipeParameters.java 66.66% 5 Missing ⚠️
...e/sink/protocol/opcua/client/IoTDBOpcUaClient.java 0.00% 2 Missing ⚠️
...iotdb/db/storageengine/load/LoadTsFileManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17063      +/-   ##
============================================
- Coverage     39.25%   39.12%   -0.13%     
  Complexity      282      282              
============================================
  Files          5105     5105              
  Lines        341457   341476      +19     
  Branches      43517    43523       +6     
============================================
- Hits         134026   133615     -411     
- Misses       207431   207861     +430     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant