Skip to content

Support NULL time in First/Last/FirstBy/LastBy aggregations #17064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alpass163 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support NULL time in First/Last/FirstBy/LastBy aggregations #17064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
445 changes: 264 additions & 181 deletions ...tdb/db/queryengine/execution/operator/source/relational/aggregation/FirstAccumulator.java
View file
Open in desktop

Large diffs are not rendered by default.

494 changes: 248 additions & 246 deletions ...b/db/queryengine/execution/operator/source/relational/aggregation/FirstByAccumulator.java
View file
Open in desktop

Large diffs are not rendered by default.

180 changes: 96 additions & 84 deletions .../queryengine/execution/operator/source/relational/aggregation/FirstByDescAccumulator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,137 +42,149 @@ public TableAccumulator copy() {
@Override
protected void addIntInput(
Column xColumn, Column yColumn, Column timeColumn, AggregationMask mask) {
int positionCount = mask.getSelectedPositionCount();
int selectPositionCount = mask.getSelectedPositionCount();

if (mask.isSelectAll()) {
for (int i = 0; i < positionCount; i++) {
if (!yColumn.isNull(i)) {
updateIntFirstValue(xColumn, i, timeColumn.getLong(i));
}
boolean isSelectAll = mask.isSelectAll();
int[] selectedPositions = isSelectAll ? null : mask.getSelectedPositions();

for (int i = 0; i < selectPositionCount; i++) {
int position = isSelectAll ? i : selectedPositions[i];
if (yColumn.isNull(position)) {
continue;
}
} else {
int[] selectedPositions = mask.getSelectedPositions();
int position;
for (int i = 0; i < positionCount; i++) {
position = selectedPositions[i];
if (!yColumn.isNull(position)) {
updateIntFirstValue(xColumn, position, timeColumn.getLong(position));
}

// Check if the time is null
if (!timeColumn.isNull(position)) {
// Case A: The order time is not null. Attempt to update the xResult.
updateIntFirstValue(
xColumn.isNull(position), xColumn.getInt(position), timeColumn.getLong(position));
} else {
// Case A: The order time is null. Attempt to update the xNullTimeValue.
updateIntNullTimeValue(xColumn.isNull(position), xColumn.getInt(position));
}
}
}

@Override
protected void addLongInput(
Column xColumn, Column yColumn, Column timeColumn, AggregationMask mask) {
int positionCount = mask.getSelectedPositionCount();
int selectPositionCount = mask.getSelectedPositionCount();

boolean isSelectAll = mask.isSelectAll();
int[] selectedPositions = isSelectAll ? null : mask.getSelectedPositions();

if (mask.isSelectAll()) {
for (int i = 0; i < positionCount; i++) {
if (!yColumn.isNull(i)) {
updateLongFirstValue(xColumn, i, timeColumn.getLong(i));
}
for (int i = 0; i < selectPositionCount; i++) {
int position = isSelectAll ? i : selectedPositions[i];
if (yColumn.isNull(position)) {
continue;
}
} else {
int[] selectedPositions = mask.getSelectedPositions();
int position;
for (int i = 0; i < positionCount; i++) {
position = selectedPositions[i];
if (!yColumn.isNull(position)) {
updateLongFirstValue(xColumn, position, timeColumn.getLong(position));
}

// Check if the time is null
if (!timeColumn.isNull(position)) {
// Case A: Valid Time
updateLongFirstValue(
xColumn.isNull(position), xColumn.getLong(position), timeColumn.getLong(position));
} else {
// Case B: Null Time
updateLongNullTimeValue(xColumn.isNull(position), xColumn.getLong(position));
}
}
}

@Override
protected void addFloatInput(
Column xColumn, Column yColumn, Column timeColumn, AggregationMask mask) {
int positionCount = mask.getSelectedPositionCount();
int selectPositionCount = mask.getSelectedPositionCount();

boolean isSelectAll = mask.isSelectAll();
int[] selectedPositions = isSelectAll ? null : mask.getSelectedPositions();

if (mask.isSelectAll()) {
for (int i = 0; i < positionCount; i++) {
if (!yColumn.isNull(i)) {
updateFloatFirstValue(xColumn, i, timeColumn.getLong(i));
}
for (int i = 0; i < selectPositionCount; i++) {
int position = isSelectAll ? i : selectedPositions[i];
if (yColumn.isNull(position)) {
continue;
}
} else {
int[] selectedPositions = mask.getSelectedPositions();
int position;
for (int i = 0; i < positionCount; i++) {
position = selectedPositions[i];
if (!yColumn.isNull(position)) {
updateFloatFirstValue(xColumn, position, timeColumn.getLong(position));
}

// Check if the time is null
if (!timeColumn.isNull(position)) {
// Case A: Valid Time
updateFloatFirstValue(
xColumn.isNull(position), xColumn.getFloat(position), timeColumn.getLong(position));
} else {
// Case B: Null Time
updateFloatNullTimeValue(xColumn.isNull(position), xColumn.getFloat(position));
}
}
}

@Override
protected void addDoubleInput(
Column xColumn, Column yColumn, Column timeColumn, AggregationMask mask) {
int positionCount = mask.getSelectedPositionCount();
int selectPositionCount = mask.getSelectedPositionCount();

if (mask.isSelectAll()) {
for (int i = 0; i < positionCount; i++) {
if (!yColumn.isNull(i)) {
updateDoubleFirstValue(xColumn, i, timeColumn.getLong(i));
}
boolean isSelectAll = mask.isSelectAll();
int[] selectedPositions = isSelectAll ? null : mask.getSelectedPositions();

for (int i = 0; i < selectPositionCount; i++) {
int position = isSelectAll ? i : selectedPositions[i];
if (yColumn.isNull(position)) {
continue;
}
} else {
int[] selectedPositions = mask.getSelectedPositions();
int position;
for (int i = 0; i < positionCount; i++) {
position = selectedPositions[i];
if (!yColumn.isNull(position)) {
updateDoubleFirstValue(xColumn, position, timeColumn.getLong(position));
}

// Check if the time is null
if (!timeColumn.isNull(position)) {
updateDoubleFirstValue(
xColumn.isNull(position), xColumn.getDouble(position), timeColumn.getLong(position));
} else {
updateDoubleNullTimeValue(xColumn.isNull(position), xColumn.getDouble(position));
}
}
}

@Override
protected void addBinaryInput(
Column xColumn, Column yColumn, Column timeColumn, AggregationMask mask) {
int positionCount = mask.getSelectedPositionCount();
int selectPositionCount = mask.getSelectedPositionCount();

boolean isSelectAll = mask.isSelectAll();
int[] selectedPositions = isSelectAll ? null : mask.getSelectedPositions();

if (mask.isSelectAll()) {
for (int i = 0; i < positionCount; i++) {
if (!yColumn.isNull(i)) {
updateBinaryFirstValue(xColumn, i, timeColumn.getLong(i));
}
for (int i = 0; i < selectPositionCount; i++) {
int position = isSelectAll ? i : selectedPositions[i];
if (yColumn.isNull(position)) {
continue;
}
} else {
int[] selectedPositions = mask.getSelectedPositions();
int position;
for (int i = 0; i < positionCount; i++) {
position = selectedPositions[i];
if (!yColumn.isNull(position)) {
updateBinaryFirstValue(xColumn, position, timeColumn.getLong(position));
}

// Check if the time is null
if (!timeColumn.isNull(position)) {
updateBinaryFirstValue(
xColumn.isNull(position), xColumn.getBinary(position), timeColumn.getLong(position));
} else {
updateBinaryNullTimeValue(xColumn.isNull(position), xColumn.getBinary(position));
}
}
}

@Override
protected void addBooleanInput(
Column xColumn, Column yColumn, Column timeColumn, AggregationMask mask) {
int positionCount = mask.getSelectedPositionCount();
int selectPositionCount = mask.getSelectedPositionCount();

boolean isSelectAll = mask.isSelectAll();
int[] selectedPositions = isSelectAll ? null : mask.getSelectedPositions();

if (mask.isSelectAll()) {
for (int i = 0; i < positionCount; i++) {
if (!yColumn.isNull(i)) {
updateBooleanFirstValue(xColumn, i, timeColumn.getLong(i));
}
for (int i = 0; i < selectPositionCount; i++) {
int position = isSelectAll ? i : selectedPositions[i];
if (yColumn.isNull(position)) {
continue;
}
} else {
int[] selectedPositions = mask.getSelectedPositions();
int position;
for (int i = 0; i < positionCount; i++) {
position = selectedPositions[i];
if (!yColumn.isNull(position)) {
updateBooleanFirstValue(xColumn, position, timeColumn.getLong(position));
}

// Check if the time is null
if (!timeColumn.isNull(position)) {
updateBooleanFirstValue(
xColumn.isNull(position), xColumn.getBoolean(position), timeColumn.getLong(position));
} else {
updateBooleanNullTimeValue(xColumn.isNull(position), xColumn.getBoolean(position));
}
}
}
Expand Down
Loading