feat(delex): Implement DELEX Command

[Valay17]

Fixes #3310

Implement DELEX Command

Digest function commented out

[PragmaTwice]

Hey thank you for your contribution, could you please add some golang test cases?

[Valay17]

Thank you @PragmaTwice, I am working on them

[git-hulk]

@Valay17 I think we could add a digest util function in this PR, so that other PRs won't block it. cc @PragmaTwice

[Valay17]

Sure, will add it as well and also update the places where I have commented it, also a question regarding the placement of the header files xxh3.h and xxhash.h, which directory would be appropriate to place it in?

[PragmaTwice]

Sure, will add it as well and also update the places where I have commented it, also a question regarding the placement of the header files xxh3.h and xxhash.h, which directory would be appropriate to place it in?

You don't need to place the header file, these will be automatically fetched and put into your build dir: https://github.com/apache/kvrocks/blob/unstable/cmake/xxhash.cmake.

You can just #include "xxh3.h".

[Valay17]

Perfect! Will add it accordingly and also change enum to struct

[Valay17]

Hi, could you please tell me what is the reason for my go test cases failure?

[PragmaTwice]

please revert this.

[PragmaTwice]

check it again.

[PragmaTwice]

All CI is still failing.

Please ensure c++ and golang tests pass before you request for review.

[Valay17]

Confirmed 3 times that both cpp and go tests are running locally, please review, thanks

[Valay17]

For clang-tidy, it is telling me this, could guide me on how to go ahead with it:
if (s.IsNotFound() || !deleted) {
| ^~~~~~~~
| deleted_
DelExOption option;
| ^~~~~~
| option_
should I rename all variables with underscores at end? or keep them as is?

also the GO test is failing for TestClusterReset, for this one:
Build and test (Darwin Clang arm64 with OpenSSL, macos-14, auto, -DENABLE_OPENSSL=ON)

all others are passing

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud