-
Notifications
You must be signed in to change notification settings - Fork 923
Only call super() during MockHttp if required #2033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
With pytest 8.2 and above, any class that contains classes is collected, which means they are instantiated, which MockHttp's superclasses do not accept, since they require keyword arguments. To work around this, only call the superclass's __init__ method if we are passed kwargs.
|
Thanks for the contribution. I've intentionally help back at upgrading pytest since we rely on test collection logic which has changed in new version of pytest so various tests are not being collected correctly. I will test and verify this change locally with latest version of pytest. |
…libcloud into s-t-e-v-e-n-k-only-call-super-if-needed
|
@s-t-e-v-e-n-k I've tested it locally and it indeed appears to be working fine. Before: After (with pytest > 8.2): I will merge it into trunk shortly. Thanks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #2033 +/- ##
==========================================
- Coverage 83.40% 83.40% -0.00%
==========================================
Files 353 353
Lines 81684 81685 +1
Branches 8631 8632 +1
==========================================
Hits 68124 68124
Misses 10738 10738
- Partials 2822 2823 +1
🚀 New features to boost your workflow:
|
Only instantiate superclasses of MockHttp if we are provided keyword arguments
Description
With pytest 8.2 and above, any class that contains tests is collected, which means they are instantiated, which MockHttp's superclasses do not accept, since they require keyword arguments. To work around this, only call the superclass's init method if we are passed kwargs.
Status
Done, ready for review
Checklist (tick everything that applies)