Add new testcase and fix old testcase. #3353
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple threads should use the same lock for resource protection. Signed-off-by: wangzhi16 <wangzhi16@xiaomi.com>
Supplement ostest test cases. Signed-off-by: wangzhi16 <wangzhi16@xiaomi.com>
There are three bug in fifo testcase. 1. line 211 and line 295 should be nbytes not ret. 2. coverity report error: CID 1667262: (apache#4 of 11): Double close (USE_AFTER_FREE) 11. double_close: Calling close(int) will close the handle fd that has already been closed. [Note: The source code implementation of this function has been overwritten by the built-in model.] Double close will ocurr when line 234 is true and goto line 341, close again! Now, Using the previous code logic, Use a tid and an errout_with_null_thread to avoid uninitialized problems. 3. since line 295 is used ret not nbytes, error not expose before. When the end of read and write are opened, end of write will write successfully even if end of read not read. Signed-off-by: wangzhi16 <wangzhi16@xiaomi.com>
xiaoxiang781216
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR series improves test reliability and fixes critical bugs in the NuttX test suite:
Testing Impact
Files Modified
Signed-off-by: wangzhi16 wangzhi16@xiaomi.com