nsh: fix nsh redirect fd double close #3364
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid double-close of redirection fds
Summary
Fix a double close() in foreground redirection. nsh_undirect() already closes the redirected fd_in/fd_out, but close_redir would close them again. Reset fd_in/fd_out to -1 after nsh_undirect() to avoid closing the same fd twice.
Impact
nsh_redirect.
Testing