Merged
Conversation
Add default values (0x0) for ARCH_TEXT_VBASE, ARCH_DATA_VBASE, and ARCH_HEAP_VBASE to resolve cmake configuration warnings when these values are not explicitly set during initialization. Signed-off-by: hujun5 <hujun5@xiaomi.com>
jerpelea
approved these changes
Jan 20, 2026
xiaoxiang781216
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes CMake configuration errors that occur during NuttX initialization when virtual address base configuration options are not explicitly set. The build system was throwing invalid value warnings for hex-type configuration options without defaults.
Changes Made
default 0x0to ARCH_TEXT_VBASE configurationdefault 0x0to ARCH_DATA_VBASE configurationdefault 0x0to ARCH_HEAP_VBASE configurationImpact
• Stability: Eliminates CMake configuration warnings during initialization
• Compatibility: No breaking changes, provides sensible defaults for optional configurations
• Code Quality: Improves build system stability and cleaner initialization output
• No breaking changes: All changes are backward compatible
Testing
Test Environment:
• Host: Linux x86_64
• Configuration: Default NuttX cmake configuration without explicit virtual address settings
Test Procedure:
Test Results:
✅ CMake initialization completes without configuration warnings
✅ Default values (0x0) properly applied to all three virtual base configurations
✅ Backward compatibility maintained for existing configurations
✅ Build successful on tested architectures
Verification:
• ✅ Configuration warnings resolved
• ✅ Build system initialization cleaner
• ✅ No regressions in existing functionality