Skip to content

Comments

arch: fix cmake error#18033

Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom
hujun260:apache_fix_cmake_error
Jan 21, 2026
Merged

arch: fix cmake error#18033
xiaoxiang781216 merged 1 commit intoapache:masterfrom
hujun260:apache_fix_cmake_error

Conversation

@hujun260
Copy link
Contributor

Summary

This PR fixes CMake configuration errors that occur during NuttX initialization when virtual address base configuration options are not explicitly set. The build system was throwing invalid value warnings for hex-type configuration options without defaults.

Changes Made

  • Add default 0x0 to ARCH_TEXT_VBASE configuration
  • Add default 0x0 to ARCH_DATA_VBASE configuration
  • Add default 0x0 to ARCH_HEAP_VBASE configuration

Impact

• Stability: Eliminates CMake configuration warnings during initialization
• Compatibility: No breaking changes, provides sensible defaults for optional configurations
• Code Quality: Improves build system stability and cleaner initialization output
• No breaking changes: All changes are backward compatible

Testing

Test Environment:

• Host: Linux x86_64
• Configuration: Default NuttX cmake configuration without explicit virtual address settings

Test Procedure:

  1. Ran NuttX cmake initialization without setting ARCH_TEXT_VBASE, ARCH_DATA_VBASE, ARCH_HEAP_VBASE
  2. Verified no cmake configuration warnings are generated
  3. Tested on multiple architectures with ARCH_ADDRENV and ARCH_NEED_ADDRENV_MAPPING enabled

Test Results:

✅ CMake initialization completes without configuration warnings
✅ Default values (0x0) properly applied to all three virtual base configurations
✅ Backward compatibility maintained for existing configurations
✅ Build successful on tested architectures

Verification:

• ✅ Configuration warnings resolved
• ✅ Build system initialization cleaner
• ✅ No regressions in existing functionality

Add default values (0x0) for ARCH_TEXT_VBASE, ARCH_DATA_VBASE, and
ARCH_HEAP_VBASE to resolve cmake configuration warnings when these
values are not explicitly set during initialization.

Signed-off-by: hujun5 <hujun5@xiaomi.com>
@github-actions github-actions bot added the Size: XS The size of the change in this PR is very small label Jan 20, 2026
@xiaoxiang781216 xiaoxiang781216 merged commit f6f8aca into apache:master Jan 21, 2026
56 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: XS The size of the change in this PR is very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants