Skip to content

Conversation

@MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Jul 7, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx requested a review from Xuanwo as a code owner July 7, 2025 05:27
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 7, 2025
@MrCroxx MrCroxx changed the title RFC: foyer layer RFC-6370: foyer layer Jul 7, 2025
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ususally don't need an RFC for new layers, but I'm happy to see one!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 7, 2025
@Xuanwo Xuanwo merged commit 620643a into apache:main Jul 7, 2025
@WenyXu
Copy link
Member

WenyXu commented Aug 26, 2025

@MrCroxx @Xuanwo Nice work! We’re also looking into a caching layer for OpenDAL in our project. Do we already have any plans for caching strategies in the range get? Maybe we can open a tracking issue and work on it together.

A hybrid approach sounds good to us—for example, caching whole objects if they’re small enough, and using page-aligned slices for bigger ones. It might also make sense to have some cache control options for writers(event readers?)—for example, being able to mark certain files so they don’t get cached at all.

@flaneur2020
Copy link
Contributor

flaneur2020 commented Jan 1, 2026

@WenyXu +1 for the page-aligned caching scheme. imho, it should be a must-have for serious production workloads.

i’m currently working on integrating Slatedb with OpenDAL in slatedb/slatedb#1104. the main blocker at the moment is to add a page-aligned caching support to OpenDAL.

currently, Slatedb has its own page-aligned caching middleware around object_store (in https://github.com/slatedb/slatedb/blob/main/slatedb/src/cached_object_store/object_store.rs) and kinda works well in production workloads. I’d like to port that implementation into the Foyer layer after #6366 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants