HDDS-14629. Code cleanup after HDDS-13906

[Russole]

What changes were proposed in this pull request?

• Refactor OMDBArchiver to own and initialize the hardlink mapping internally, removing setHardLinkFileMap() and nullable state.
• Normalize and convert paths to absolute form before calling relativize() in writeHardlinkFile to prevent abs/relative path mismatch exceptions.
• Stop exposing internal hardlink map and use recordHardLinkMapping() instead.
• Return HTTP 500 when archive streaming fails to ensure proper error handling.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14629

How was this patch tested?

• All tests passed except those currently pending fixes
  • https://github.com/Russole/ozone/actions/runs/22050572851

[yandrey321]

can this one be null or empty?

[Russole]

dbFile comes from either Files.list(...) or from a List<Path> created in extractSSTFilesFromCompactionLog().

From directory listing:

try (Stream<Path> files = Files.list(dbDir)) {
  collectFilesFromDir(..., files, ...);
}

From compaction log (in extractSSTFilesFromCompactionLog()):

sstFiles.add(sstBackupDir.resolve(f.getFileName() + ROCKSDB_SST_SUFFIX));

In both cases, dbFile is a valid Path (no null elements). Also, Path.resolve() never returns null — it returns a Path or throws NullPointerException if the argument is null.

So dbFile.toFile().getAbsolutePath() cannot be null in this flow.

[Russole]

Thanks @yandrey321 for the review.

[Gargi-jais11]

Thanks @Russole for the patch.
Please find inlined comments.

[Gargi-jais11]

The temporary file data created is never cleaned up. Consider wrapping the logic around try block and delete the temp file in a finally block. Without this fix, every checkpoint operation creates an orphned temp file. Over time, this will consume disk space and could eventually cause the system to run out of space, leading to operation failures.

Path data = Files.createTempFile(DATA_PREFIX, DATA_SUFFIX);
  try {
    Path metaDirPath = OMStorage.getOmDbDir(conf).toPath()
        .toAbsolutePath().normalize();
    StringBuilder sb = new StringBuilder();

    for (Map.Entry<String, String> entry : hardlinkFileMap.entrySet()) {
      Path p = new File(entry.getKey()).toPath();
      if (!p.isAbsolute()) {
        p = metaDirPath.resolve(p);
      }
      p = p.toAbsolutePath().normalize();
      String fileId = entry.getValue();
      Path relativePath = metaDirPath.relativize(p);
      sb.append(relativePath).append('\t').append(fileId).append('\n');
    }
    Files.write(data, sb.toString().getBytes(StandardCharsets.UTF_8), StandardOpenOption.TRUNCATE_EXISTING);
    includeFile(data.toFile(), OmSnapshotManager.OM_HARDLINK_FILE, archiveOutputStream);
  } finally {
    Files.deleteIfExists(data);
  }

[Russole]

Thanks for the suggestion, @Gargi-jais11. The temp file is now deleted in a finally block.

[Russole]

@jojochuang Hi, this PR is currently under review.
If you have a chance, I’d really appreciate your feedback as well. Thanks!

[yandrey321]

lgtm

[Gargi-jais11]

LGTM

[Gargi-jais11]

@jojochuang Please review the PR.