Skip to content

Conversation

@Fokko
Copy link
Contributor

@Fokko Fokko commented Nov 7, 2024

Adds support for JDK21+:

Or see: https://endoflife.date/scala#jdk-compatibility

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@pan3793
Copy link
Member

pan3793 commented Nov 7, 2024

Is the parquet-scala module actually being used?

@Fokko
Copy link
Contributor Author

Fokko commented Nov 7, 2024

@pan3793 I don't have full visibility on that, but it doesn't like it, looking at Usages in Maven Central: https://mvnrepository.com/artifact/org.apache.parquet/parquet-scala

Might be good to see if we can retire some modules that are not used anymore (I think parquet-pig is also another good candidate).

@pan3793
Copy link
Member

pan3793 commented Nov 7, 2024

+1 for retiring the parquet-scala module, or even dropping it directly.

there is only one class in the parquet-scala module, users are easy to copy and embed it if we drop the parquet-scala module.

additionally, it's rare to publish a scala lib that only supports a single scala binary version, most scala libs support 2~3 scala binary versions in each version

@Fokko
Copy link
Contributor Author

Fokko commented Nov 7, 2024

@pan3793 I agree, are you interested in raising a [DISCUSS] on the mailinglist?

@pan3793
Copy link
Member

pan3793 commented Nov 7, 2024

@Fokko https://lists.apache.org/thread/scdq9t2gvvs4glhq0qx4qcvfp62j793s

@Fokko
Copy link
Contributor Author

Fokko commented Nov 15, 2024

Closing this in favor of #3063

@Fokko Fokko closed this Nov 15, 2024
@Fokko Fokko deleted the fd-scala branch November 15, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants