PHOENIX-7623: Add a profile which runs ITs with phoenix ha client#2205
PHOENIX-7623: Add a profile which runs ITs with phoenix ha client#2205Divneet18 wants to merge 4 commits intoapache:PHOENIX-7623-featurefrom
Conversation
|
There are some merge conflicts |
There was a problem hiding this comment.
Change to constant in HAGroup
| url = haGroup.getRoleRecord().getActiveUrl(); | ||
| if (url.isPresent()) { | ||
| return url.get() + ";" + PHOENIX_TEST_DRIVER_URL_PARAM; | ||
| } else { |
There was a problem hiding this comment.
remove else block
lokiore
left a comment
lokiore
left a comment
There was a problem hiding this comment.
Took initial look, some comments and questions
one suggestion, if we have failing tests which can't be run in HA Mode, maybe exclude them in pom for HA test profile so that for default they run as it is
There was a problem hiding this comment.
Can we use runOnConnections() for these methods, we are not using parallel policy for tests but if we want to then it will be helpful?
There was a problem hiding this comment.
If all the tests in PR here are passing then we can start removing these comments
There was a problem hiding this comment.
Can we make phoenix.ha.profile.active a constant.
There was a problem hiding this comment.
Is this test still failing?
There was a problem hiding this comment.
If these exceptions are expected, then please add a comment that this is expected.
There was a problem hiding this comment.
Please don't use * imports
| conf = HBaseConfiguration.create(); | ||
| hbaseTestUtil = new HBaseTestingUtility(conf); | ||
| setUpConfigForMiniCluster(conf); | ||
| conf.set(QueryServices.EXTRA_JDBC_ARGUMENTS_ATTRIB, QueryServicesOptions.DEFAULT_EXTRA_JDBC_ARGUMENTS); |
There was a problem hiding this comment.
why are we not passing this prop in conf for HA mode?
There was a problem hiding this comment.
This test is not being run, no change needed here
There was a problem hiding this comment.
same here don't ignore for default mode
|
Does the feature branch have spotless format? i.e. is it upto date with master branch? |
3 participants
No description provided.