Skip to content

Conversation

@humkum
Copy link
Contributor

@humkum humkum commented Jan 8, 2026

Which Issue(s) This PR Fixes

Fixes #9984

Brief Description

slave broker delete all topic config and subGroup config when sync meta data from master. The deletion operation should only be performed when the topic no longer exists on the master node and the corresponding deletion logic already exists.

@humkum humkum changed the title [ISSUE #9984]fix: slave delete all topic config and subGroup config when sync config from master [ISSUE #9984] fix: slave delete all topic config and subGroup config when sync config from master Jan 8, 2026
@humkum humkum changed the title [ISSUE #9984] fix: slave delete all topic config and subGroup config when sync config from master [ISSUE #9984] Fix: slave delete all topic config and subGroup config when sync config from master Jan 8, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.79%. Comparing base (7fc5452) to head (92f0ca7).
⚠️ Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...apache/rocketmq/broker/slave/SlaveSynchronize.java 87.50% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9996      +/-   ##
=============================================
- Coverage      48.85%   48.79%   -0.06%     
+ Complexity     12789    12771      -18     
=============================================
  Files           1327     1327              
  Lines          96441    96444       +3     
  Branches       12440    12442       +2     
=============================================
- Hits           47115    47059      -56     
- Misses         43586    43619      +33     
- Partials        5740     5766      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] auto delete topics when in Master-Slave Automatic Failover Mode

3 participants