Skip to content

[#4877] not clear service instances cache when pull instance exception and add telnet check #4878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
humingcheng merged 3 commits into from
Aug 26, 2025
Merged

[#4877] not clear service instances cache when pull instance exception and add telnet check #4878

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1679770
[#4877] not clear service instances cache when pull instance exceptio…
chengyouling Jul 15, 2025
e390f8d
adjust endpoint health check
chengyouling Jul 29, 2025
679e266
remove instance healthcheck
chengyouling Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 7 additions & 22 deletions ...nt/src/main/java/org/apache/servicecomb/service/center/client/ServiceCenterDiscovery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@

package org.apache.servicecomb.service.center.client;

import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -153,13 +151,12 @@ public void onPullInstanceEvent(PullInstanceEvent event) {
startTask(new PullInstanceOnceTask());
}

private List<SubscriptionKey> pullInstance(SubscriptionKey k, SubscriptionValue v, boolean sendChangedEvent) {
private void pullInstance(SubscriptionKey k, SubscriptionValue v, boolean sendChangedEvent) {
if (myselfServiceId == null) {
// registration not ready
return Collections.emptyList();
return;
}

List<SubscriptionKey> failedKeys = new ArrayList<>();
try {
FindMicroserviceInstancesResponse instancesResponse = serviceCenterClient
.findMicroserviceInstance(myselfServiceId, k.appId, k.serviceName, ALL_VERSION, v.revision);
Expand All @@ -186,17 +183,9 @@ private List<SubscriptionKey> pullInstance(SubscriptionKey k, SubscriptionValue
}
}
} catch (Exception e) {
if (!(e.getCause() instanceof IOException)) {
// for IOException, do not remove cache, or when service center
// not available, invocation between microservices will fail.
failedKeys.add(k);
LOGGER.error("find service {}#{} instance failed and remove local cache.", k.appId, k.serviceName, e);
} else {
LOGGER.warn("find service {}#{} instance failed, remaining local instances cache, cause message: {}",
k.appId, k.serviceName, e.getMessage());
}
LOGGER.warn("find service {}#{} instance failed, remaining local instances cache [{}], cause message: {}",
k.appId, k.serviceName, instanceToString(v.instancesCache), e.getMessage());
}
return failedKeys;
}

private void setMicroserviceInfo(List<MicroserviceInstance> instances) {
Expand Down Expand Up @@ -235,13 +224,9 @@ public void execute() {
}

private synchronized void pullAllInstance() {
List<SubscriptionKey> failedInstances = new ArrayList<>();
instancesCache.forEach((k, v) -> failedInstances.addAll(pullInstance(k, v, true)));
if (failedInstances.isEmpty()) {
return;
}
failedInstances.forEach(instancesCache::remove);
failedInstances.clear();
instancesCache.forEach((k, v) -> {
pullInstance(k, v, true);
});
}

private static String instanceToString(List<MicroserviceInstance> instances) {
Expand Down
Loading