Skip to content

[#4970] Change MessageTest unit tests to deterministic implementation #4971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liubao68 merged 1 commit into from
Oct 10, 2025
+15 −4
Merged

[#4970] Change MessageTest unit tests to deterministic implementation #4971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions ...ry-lightweight/src/test/java/org/apache/servicecomb/registry/lightweight/MessageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@
package org.apache.servicecomb.registry.lightweight;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.fail;

import org.junit.jupiter.api.Test;

import io.vertx.core.json.Json;
import org.skyscreamer.jsonassert.JSONAssert;

class MessageTest {
private String toLinuxPrettyJson(Object value) {
Expand All @@ -33,7 +35,8 @@ private String toLinuxPrettyJson(Object value) {
void should_encode_register_type() {
Message<RegisterRequest> msg = Message.of(MessageType.REGISTER, new RegisterRequest());

assertThat(toLinuxPrettyJson(msg)).isEqualTo(""
try {
JSONAssert.assertEquals(toLinuxPrettyJson(msg), ""
+ "{\n"
+ " \"type\" : \"REGISTER\",\n"
+ " \"body\" : {\n"
Expand All @@ -45,7 +48,11 @@ void should_encode_register_type() {
+ " \"status\" : null,\n"
+ " \"endpoints\" : null\n"
+ " }\n"
+ "}");
+ "}", false);
} catch (Exception e) {
fail("Failed to compare JSONs: " + e.getMessage(), e);
}

}

@Test
Expand All @@ -60,14 +67,18 @@ void should_decode_register_type() {
void should_encode_unregister_type() {
Message<UnregisterRequest> msg = Message.of(MessageType.UNREGISTER, new UnregisterRequest());

assertThat(toLinuxPrettyJson(msg)).isEqualTo(""
try {
JSONAssert.assertEquals(toLinuxPrettyJson(msg), ""
+ "{\n"
+ " \"type\" : \"UNREGISTER\",\n"
+ " \"body\" : {\n"
+ " \"serviceId\" : null,\n"
+ " \"instanceId\" : null\n"
+ " }\n"
+ "}");
+ "}", false);
} catch (Exception e) {
fail("Failed to compare JSONs: " + e.getMessage(), e);
}
}

@Test
Expand Down
Loading