[#4966] Fixing flaky test UnitTestSwaggerUtils#testSwagger without adding dependencies
#4984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
pem70
force-pushed
the
fix-testSchemaMethod
branch
from
84cab4a to
a5c1c20
Compare
Member
|
ci跑错了，看下什么问题，然后看下格式问题，我们用的是Google Java style |
pem70
force-pushed
the
fix-testSchemaMethod
branch
from
a5c1c20 to
856f2c7
Compare
Contributor
Author
格式问题已修改，我在本地验证了ci报错的那个测试用例，它在本地是通过的 |
Update TestSwagger without adding dependencies Update UnitTestSwaggerUtils.java Remove unused import
pem70
force-pushed
the
fix-testSchemaMethod
branch
from
856f2c7 to
4823d3e
Compare
Contributor
Author
|
已rebase, ci问题应已解决 |
Member
|
that's great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The method
testSwagger ()inUnitTestSwaggerUtilsfrom moduleswagger/swagger-generator/generator-corecompares pretty-printed YAML strings to verify correctness. However, since the OpenAPI object is constructed withMap/Setiteration, the key order in the serialized YAML is non-deterministic. When the iteration order changes, the string comparison fails, resulting in flaky behavior.This test was flagged by the NonDex tool, which detects unreliable tests caused by hidden assumptions in Java API ordering. To reproduce, run an upper test that calls
testSwagger, for example:Affected Tests
This change fixes the below tests:
org.apache.servicecomb.swagger.generator.core.TestPojo.testResponseEntityorg.apache.servicecomb.swagger.generator.core.TestSwaggerUtils.testSchemaMethodorg.apache.servicecomb.swagger.generator.core.TestPojoExample.testPojoExample1Fix
Instead of comparing raw YAML strings or using JSONAssert as my previous PR, the new implementation parses both expected and actual OpenAPI YAML into JsonNode objects using Jackson’s ObjectMapper and YAMLFactory.
It then checks structural equality via JsonNode.equals(), ensuring order-insensitive comparison while preserving strict value matching.
Rerunning NonDex with this change shows a stable passing result.
PR Checklist
UnitTestSwaggerUtils#testSwagger(#4966 )mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.[SCB-XXX], where you replaceSCB-XXXwith the appropriate JIRA issue.