Skip to content

Conversation

@anthonyx24
Copy link
Contributor

Issue: See #4987.

Fix: The fix here is the same as previously merged PRs such as #4969 and #4971. I use JSONAssert's assertEquals() method, using non-strict checking (which ignores parameter ordering). This compares the JSON strings without enforcing parameter ordering, which removes the potentially unreliable nature of these tests. This library is already included within in the project, so there's no need to update the pom file. Rerunning Nondex shows a passing result.

PR Checklist:

  • Github Issue: [BUG] - Nondeterminism in unit test within HighwayServerCodecFilterTest due to JSON parameter ordering #4987
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.

@SweetWuXiaoMei
Copy link
Member

lgtm

@SweetWuXiaoMei SweetWuXiaoMei merged commit 75417d8 into apache:master Oct 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants