Skip to content

Conversation

@pem70
Copy link
Contributor

@pem70 pem70 commented Oct 23, 2025

Issue

Test EndpointTest#should_ignore_endpoint_when_generate_swagger is flaky. See #4989

Fix

While the original test compares the full serialized YAML string, this fix removes the fragile YAML string comparison and checks key fields in the generated OpenAPI object instead. It keeps the same intent as it verifies the expected endpoint and response, while avoiding failures caused by nondeterministic field order or formatting.

Checklist

  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@pem70
Copy link
Contributor Author

pem70 commented Oct 27, 2025

已rebase, ci问题应已解决

@SweetWuXiaoMei SweetWuXiaoMei merged commit d4db7c3 into apache:master Oct 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants