Skip to content

Conversation

@pem70
Copy link
Contributor

@pem70 pem70 commented Oct 23, 2025

Issue

Test CommonExceptionDataTest#should_include_code_in_json_when_code_is_not_null is flaky. See #4991

Fix

This fix decodes the JSON and asserts the key–value pairs on a map, so the test checks semantic content instead of exact string formatting or key order. It keeps the original goal of verifying that both "code" and "message" fields have the correct values, while removing flakiness caused by unpredictable key ordering during JSON serialization.

Checklist

  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@pem70 pem70 marked this pull request as draft October 27, 2025 05:06
@pem70 pem70 force-pushed the fix-should_include_code_in_json_when_code_is_not_null branch from 58b871b to 019223c Compare October 27, 2025 05:09
@pem70 pem70 force-pushed the fix-should_include_code_in_json_when_code_is_not_null branch from 51c831d to 42acf22 Compare October 27, 2025 05:14
@pem70 pem70 marked this pull request as ready for review October 27, 2025 05:14
@pem70
Copy link
Contributor Author

pem70 commented Oct 27, 2025

已rebase, ci问题应已解决

@SweetWuXiaoMei SweetWuXiaoMei merged commit 2e1a12a into apache:master Oct 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants