Skip to content

Conversation

@anthonyx24
Copy link
Contributor

Issue: See #4993. To summarize, since the groups HashMap is unordered, using Matchers.contains, which does strict order checking, can result in a test failure since the key iteration order isn't guaranteed.

Fix: I simply replace Matchers.contains with Matchers.containsInAnyOrder, since it doesn't do strict order checking.

PR Checklist:

  • Github Issue: [BUG] - Nondeterminism in TestMeasurementGroupConfig due to strict order checking of keys in an unordered HashMap #4993
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.

@SweetWuXiaoMei SweetWuXiaoMei merged commit e56086d into apache:master Oct 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants