SLING-9820 add JcrInstallMojo to upload content-package artifacts to JCR#3
SLING-9820 add JcrInstallMojo to upload content-package artifacts to JCR#3adamcin wants to merge 1 commit intoapache:masterfrom
Conversation
adamcin
force-pushed
the
SLING-9820
branch
3 times, most recently
from
62e93a2 to
14feb09
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@kwin - I see you've been involved in the conversations from Jira. Do you want to take this one? |
| * | ||
| * @since 2.5.0 | ||
| */ | ||
| @Mojo(name = "jcr-install", defaultPhase = LifecyclePhase.INSTALL) |
There was a problem hiding this comment.
I would rather tend to merge this functionality into the existing sling:install mojo. To be backwards compatible one should be forced into opt in via a switch like artifactExtensions which should by default only be jar. Also from a naming perspective this is not bound to JCR but supports arbitrary resources (at least for the SlingPostServlet deployment method). Obviously this requires adjusting the description of the sling:install mojo (to cover all types of artifacts which are configured via artifactExtensions). Also the parameter bundleFileName would need some clarification.
There was a problem hiding this comment.
I agree with @kwin. It could be interesting to use the same mechanism to install other resources, e.g. feature archives (FAR).
|
Kudos, SonarCloud Quality Gate passed! |
4 participants
No description provided.