Restore the explicit closes on solr clients in test to prevent resource starvation #3995
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation when running tests many times
dsmiley
requested changes
Dec 31, 2025
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
It's impossilbe that this fixes the problem. I still see the problem with this change.
Contributor
Author
|
Any more details? I was disappointed by this fix, but it did make the Gradle test command pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to the PR #3947 where the explicit closing of
SolrClient's inDistributedDebugComponentTestfailed.This now passes: