[SPARK-54896] Improve Helm templates to use Spark Operator HA feature easily #437
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashangit
force-pushed
the
nfraison/high-availability
branch
from
7024b3a to
a7ebc51
Compare
Member
|
cc @jiangzho ? |
|
|
||
| {{- if gt (int .Values.operatorDeployment.replicas) 1 }} | ||
| --- | ||
| apiVersion: policy/v1beta1 |
Member
There was a problem hiding this comment.
policy/v1 instead of policy/v1beta1?
dongjoon-hyun
changed the title
| maxUnavailable: 1 | ||
| selector: | ||
| matchLabels: | ||
| app: spark-apache-operator |
Member
There was a problem hiding this comment.
I'm wondering if this is working correctly or not because we don't use app=spark-apache-operator label.
$ kubectl get pod --show-labels
NAME READY STATUS RESTARTS AGE LABELS
spark-kubernetes-operator-5f9d958469-pckdj 1/1 Running 0 78s app.kubernetes.io/component=operator-deployment,app.kubernetes.io/name=spark-kubernetes-operator,pod-template-hash=5f9d958469,spark-role=operator
spark-kubernetes-operator-5f9d958469-xck2k 1/1 Running 0 78s app.kubernetes.io/component=operator-deployment,app.kubernetes.io/name=spark-kubernetes-operator,pod-template-hash=5f9d958469,spark-role=operator
spark-kubernetes-operator-5f9d958469-xjmpx 1/1 Running 0 78s app.kubernetes.io/component=operator-deployment,app.kubernetes.io/name=spark-kubernetes-operator,pod-template-hash=5f9d958469,spark-role=operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set default configuration on the helm template in order to support high availability of the operator without requiring specific configuration from the user
Why are the changes needed?
Simplify setup of HA, only need to increase the number of replicas
Does this PR introduce any user-facing change?
No
How was this patch tested?
Run helm template with 1 and more replicas to check that added resources are well displayed
Deployed on a local kubernetes cluster with replicas set to 3
Was this patch authored or co-authored using generative AI tooling?
No