TIKA-4290: Need to use returned value of substring() #1869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
There are two typos |
Contributor
|
Do you have an example where this part of the code is used, i.e. did you hit a file where it happened? Or did you look at the source code and you or the IDE noticed the bug? |
Contributor
Author
|
@THausherr It's result of code inspection, I've got more to show in additional PRs. |
Contributor
|
Please include "TIKA-4290: " in front of your PR title, and further PRs that deal with bugs / real risks. Don't submit PRs about formatting or style issues or pet peeves. For some reason the boilerplate text didn't appear in your PR, see e.g. #1860. I've created https://issues.apache.org/jira/browse/TIKA-4290 for you. |
dk2k
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIKA-4290: Need to use returned value of substring()