-
Notifications
You must be signed in to change notification settings - Fork 852
Implement RFC 9213 Targeted HTTP Cache Control #12679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bneradt
wants to merge
3
commits into
apache:master
Choose a base branch
from
bneradt:targeted_cache_control
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3713,7 +3713,8 @@ MIMEHdrImpl::recompute_accelerators_and_presence_bits() | |
| //////////////////////////////////////////////////////// | ||
|
|
||
| void | ||
| MIMEHdrImpl::recompute_cooked_stuff(MIMEField *changing_field_or_null) | ||
| MIMEHdrImpl::recompute_cooked_stuff(MIMEField *changing_field_or_null, const std::string_view *targeted_headers, | ||
| size_t targeted_headers_count) | ||
| { | ||
| int len, tlen; | ||
| const char *s; | ||
|
|
@@ -3725,13 +3726,26 @@ MIMEHdrImpl::recompute_cooked_stuff(MIMEField *changing_field_or_null) | |
|
|
||
| mime_hdr_cooked_stuff_init(this, changing_field_or_null); | ||
|
|
||
| ////////////////////////////////////////////////// | ||
| // (1) cook the Cache-Control header if present // | ||
| ////////////////////////////////////////////////// | ||
| ///////////////////////////////////////////////////////////////////////////// | ||
| // (1) cook the Cache-Control header (or targeted variant) if present // | ||
| ///////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| // to be safe, recompute unless you know this call is for other cooked field | ||
| if ((changing_field_or_null == nullptr) || (changing_field_or_null->m_wks_idx != MIME_WKSIDX_PRAGMA)) { | ||
| field = mime_hdr_field_find(this, static_cast<std::string_view>(MIME_FIELD_CACHE_CONTROL)); | ||
| field = nullptr; | ||
|
|
||
| // Check for targeted cache control headers first (in priority order). | ||
| for (size_t i = 0; i < targeted_headers_count; ++i) { | ||
| field = mime_hdr_field_find(this, targeted_headers[i]); | ||
| if (field) { | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| // If no targeted header was found, fall back to standard Cache-Control. | ||
| if (!field) { | ||
| field = mime_hdr_field_find(this, static_cast<std::string_view>(MIME_FIELD_CACHE_CONTROL)); | ||
| } | ||
|
Comment on lines
3735
to
3748
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the actualy interesting production change (part 1). |
||
|
|
||
| if (field) { | ||
| // try pathpaths first -- unlike most other fastpaths, this one | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recompute_cooked_stuffnow selects a targeted cache-control header based on thetargeted_headersparameters, but most existing callers (including the automatic recompute paths triggered by header field mutations) will use the defaults and therefore ignore targeted headers. This means any later modification toCache-Control/ targeted headers can recook using only the standard header and override the targeted behavior. Consider making targeted-header selection part of the header object’s state (or otherwise ensuring all recook call sites that can run before cache decisions provide the transaction’s targeted header list).