Skip to content

Fix HostDBInfo::is_down condition #12846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masaori335 wants to merge 3 commits into
base: master
Choose a base branch
from
+14 −1
Open

Fix HostDBInfo::is_down condition #12846

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c17e62
Fix HostDBInfo::is_down condition
masaori335 Feb 2, 2026
c0735a3
Add comments
masaori335 Feb 3, 2026
a877c50
Polish commnet
masaori335 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion include/iocore/hostdb/HostDBProcessor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,11 +229,24 @@ HostDBInfo::is_alive()
return this->last_fail_time() == TS_TIME_ZERO;
}

/**
Check if this HostDBInfo is currently marked DOWN (true) or UP (false). Returns true while within the `fail_window` period after
`last_failure`. Once `fail_window` expires, the host is treated as UP and this function returns false.
|<-- fail_window -->|
----------------+-------------------+-----------------> time
UP | DOWN | UP
(is_down=false) | (is_down=true) | (is_down=false)
| |
^ ^
\ \
last_failure last_failure + fail_window
*/
inline bool
HostDBInfo::is_down(ts_time now, ts_seconds fail_window)
{
auto last_fail = this->last_fail_time();
return (last_fail != TS_TIME_ZERO) && (last_fail + fail_window < now);
return (last_fail != TS_TIME_ZERO) && (now <= last_fail + fail_window);
}

inline bool
Expand Down