Skip to content

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented Jan 29, 2026

Why

The Nightly Docker Update CI workflow fails with NameError: name 'Sh' is not defined because Sh is used but not imported.

https://github.com/apache/tvm/actions/workflows/nightly_docker_update.yml

How

  • Add Sh to the import from cmd_utils
  • Sort the import with ruff

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical NameError that was causing the Nightly Docker Update CI workflow to fail. The issue stemmed from the Sh utility being invoked without a proper import statement. By adding Sh to the import list from cmd_utils, the workflow is now correctly configured to execute without encountering this runtime error, ensuring the stability and reliability of the automated Docker update process.

Highlights

  • CI Workflow Fix: Resolved a NameError in the Nightly Docker Update CI workflow that occurred because the Sh utility was used without being imported.
  • Import Statement Update: Modified the ci/scripts/jenkins/open_docker_update_pr.py file to explicitly import Sh from cmd_utils.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly resolves a NameError in the nightly Docker update workflow by importing the Sh utility. In addition to the fix, the imports in ci/scripts/jenkins/open_docker_update_pr.py have been reorganized to follow PEP 8 guidelines, improving code style and readability. The changes are correct and well-implemented. I have no further suggestions.

@guan404ming guan404ming marked this pull request as ready for review January 29, 2026 03:05
@guan404ming guan404ming changed the title Fix NameError in nightly docker update workflow [CI] Fix NameError in nightly docker update workflow Jan 29, 2026
@guan404ming
Copy link
Member Author

cc @tqchen

@tlopex tlopex merged commit efdf2b2 into apache:main Feb 3, 2026
17 checks passed
@guan404ming
Copy link
Member Author

Thanks!

@guan404ming guan404ming deleted the fix-nightly-docker-update branch February 3, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants