Skip to content

Conversation

@seekskyworld
Copy link

@seekskyworld seekskyworld commented Jan 15, 2026

Issue: https://issues.apache.org/jira/browse/ZOOKEEPER-5013

Summary:

  • initialize MainThread member fields in the constructor chain that writes dynamic/static configs

Motivation:

  • avoid incorrect defaults (0/null) when tests query MainThread metadata

Validation:

  • not run (not requested)

@anmolnar
Copy link
Contributor

Please don't create test classes for test classes, otherwise you should write a test class for your test class which tests another class. When you're ready, you should write another test class which tests the test class that tests the previous test class, and so on...

@anmolnar
Copy link
Contributor

Patches should be opened against the master branch at the first place.

Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments above.

Signed-off-by: seekskyworld <djh1813553759@gmail.com>
@seekskyworld seekskyworld force-pushed the fix/5013-mainthread-init branch from eec805d to 5fed23b Compare January 21, 2026 01:50
@seekskyworld seekskyworld changed the base branch from branch-3.9 to master January 21, 2026 01:50
@seekskyworld
Copy link
Author

@anmolnar Thanks for the feedback. I removed the test-class-for-test-class and kept only the MainThread field initialization. I
also retargeted the PR to master and force-pushed the updated branch. The diff now only touches
QuorumPeerTestBase.java. Please let me know if you want any additional changes or validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants