-
-
Notifications
You must be signed in to change notification settings - Fork 957
fix: add support for normalization/denormalization with attributes #7629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Maxcastel
wants to merge
6
commits into
api-platform:4.2
Choose a base branch
from
Maxcastel:fix/json-schema-api-docs-serialization-attributes
base: 4.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+650
−21
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f6509a6
fix(jsonschema): add support for attributes
Maxcastel 04f9c48
fix(metadata): add support for normalization/denormalization with att…
Maxcastel 16a593a
fix(jsonschema): add support for normalization/denormalization with a…
Maxcastel 9eed58a
fix: fix JsonSchema/Tests/SchemaFactoryTest::testBuildSchemaWithSeria…
Maxcastel 5f80311
test: add functional test for JsonSchema generation
Maxcastel aa28771
test: only key when value and key are are string in DefinitionNameFac…
Maxcastel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
src/JsonSchema/Tests/Fixtures/ApiResource/ChildAttributeDummy.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the API Platform project. | ||
| * | ||
| * (c) Kévin Dunglas <dunglas@gmail.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace ApiPlatform\JsonSchema\Tests\Fixtures\ApiResource; | ||
|
|
||
| use ApiPlatform\Metadata\ApiResource; | ||
| use Doctrine\ORM\Mapping as ORM; | ||
|
|
||
| #[ORM\Entity] | ||
| #[ApiResource] | ||
| class ChildAttributeDummy | ||
| { | ||
| #[ORM\Id] | ||
| #[ORM\GeneratedValue] | ||
| #[ORM\Column] | ||
| private ?int $id = null; | ||
|
|
||
| #[ORM\Column(length: 255)] | ||
| private ?string $name = null; | ||
|
|
||
| #[ORM\Column(length: 50)] | ||
| private ?string $code = null; | ||
|
|
||
| public function getId(): ?int | ||
| { | ||
| return $this->id; | ||
| } | ||
|
|
||
| public function getName(): ?string | ||
| { | ||
| return $this->name; | ||
| } | ||
|
|
||
| public function setName(string $name): self | ||
| { | ||
| $this->name = $name; | ||
|
|
||
| return $this; | ||
| } | ||
|
|
||
| public function getCode(): ?string | ||
| { | ||
| return $this->code; | ||
| } | ||
|
|
||
| public function setCode(string $code): self | ||
| { | ||
| $this->code = $code; | ||
|
|
||
| return $this; | ||
| } | ||
| } |
84 changes: 84 additions & 0 deletions
84
src/JsonSchema/Tests/Fixtures/ApiResource/ParentAttributeDummy.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the API Platform project. | ||
| * | ||
| * (c) Kévin Dunglas <dunglas@gmail.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace ApiPlatform\JsonSchema\Tests\Fixtures\ApiResource; | ||
|
|
||
| use ApiPlatform\Metadata\ApiResource; | ||
| use ApiPlatform\Metadata\Get; | ||
| use Doctrine\ORM\Mapping as ORM; | ||
|
|
||
| #[ORM\Entity] | ||
| #[ApiResource( | ||
| operations: [ | ||
| new Get( | ||
| normalizationContext: ['attributes' => ['title', 'child' => ['name']]] | ||
| ), | ||
| ] | ||
| )] | ||
| class ParentAttributeDummy | ||
| { | ||
| #[ORM\Id] | ||
| #[ORM\GeneratedValue] | ||
| #[ORM\Column] | ||
| private ?int $id = null; | ||
|
|
||
| #[ORM\Column(length: 255)] | ||
| private ?string $title = null; | ||
|
|
||
| #[ORM\Column(type: 'text')] | ||
| private ?string $description = null; | ||
|
|
||
| #[ORM\ManyToOne(targetEntity: ChildAttributeDummy::class)] | ||
| private ?ChildAttributeDummy $child = null; | ||
|
|
||
| public function getId(): ?int | ||
| { | ||
| return $this->id; | ||
| } | ||
|
|
||
| public function getTitle(): ?string | ||
| { | ||
| return $this->title; | ||
| } | ||
|
|
||
| public function setTitle(string $title): self | ||
| { | ||
| $this->title = $title; | ||
|
|
||
| return $this; | ||
| } | ||
|
|
||
| public function getDescription(): ?string | ||
| { | ||
| return $this->description; | ||
| } | ||
|
|
||
| public function setDescription(string $description): self | ||
| { | ||
| $this->description = $description; | ||
|
|
||
| return $this; | ||
| } | ||
|
|
||
| public function getChild(): ?ChildAttributeDummy | ||
| { | ||
| return $this->child; | ||
| } | ||
|
|
||
| public function setChild(?ChildAttributeDummy $child): self | ||
| { | ||
| $this->child = $child; | ||
|
|
||
| return $this; | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.