fix: remove extra empty lines insertion in SymfonyServiceClassConstantFixer#7761
Open
Maxcastel wants to merge 1 commit intoapi-platform:4.2from
Open
fix: remove extra empty lines insertion in SymfonyServiceClassConstantFixer#7761Maxcastel wants to merge 1 commit intoapi-platform:4.2from
Maxcastel wants to merge 1 commit intoapi-platform:4.2from
Conversation
Maxcastel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #7706
Description
When running PHP CS Fixer, extra empty lines are added when
usestatements are added bySymfonyServiceClassConstantFixer::insertImports().How to reproduce
git revert 26302584a973c326dc627bda98895095cdd5bc54(or just modify a file manually)vendor/bin/php-cs-fixer fixBefore
After