feat: support more gateway config #245
Merged
+28
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nic-6443
reviewed
Jan 14, 2026
Comment on lines
200
to
204
| keepalive_timeout: {{ default "60s" .Values.nginx.http.keepaliveTimeout }} # timeout during which a keep-alive client connection will stay open on the server side. | ||
| client_header_timeout: {{ default "60s" .Values.nginx.http.clientHeaderTimeout }} # timeout for reading client request header, then 408 (Request Time-out) error is returned to the client | ||
| client_body_timeout: {{ default "60s" .Values.nginx.http.clientBodyTimeout }} # timeout for reading client request body, then 408 (Request Time-out) error is returned to the client | ||
| send_timeout: {{ default "10s" .Values.nginx.http.sendTimeout }} # timeout for transmitting a response to the client.then the connection is closed | ||
| client_max_body_size: {{ default 0 .Values.nginx.http.clientMaxBodySize }} # The maximum allowed size of the client request body. |
Contributor
There was a problem hiding this comment.
No need to use default xx, the values in values.yaml have this effect, you see other fields don't write this.
nic-6443
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support some
nginx_config.http.xconfig