Conversation
Contributor
janbuchar
commented
Jun 9, 2025
- closes Refactor client timeouts - parity with Python implemenation #685
- modelled after refactor: Rework client timeout apify-client-python#384
B4nan
reviewed
Jun 10, 2025
barjin
requested changes
Jun 10, 2025
Member
barjin
left a comment
There was a problem hiding this comment.
+1 for extracting the consts somewhere, so we don't have those in multiple places
Contributor
Author
|
Sorry for the confusion around secs/millis - I changed my approach when working on this and stopped when the client_timeouts test started to pass 🤦 |
barjin
approved these changes
Jun 10, 2025
B4nan
reviewed
Jun 10, 2025
B4nan
approved these changes
Jun 10, 2025
Contributor
Author
Contributor
Basically same issue like: |
B4nan
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.