Conversation
TC-MO
added
documentation
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Comment @cursor review or bugbot run to trigger another review on this PR
| rewrite ^/api/client/python/?$ /api/client/python/docs/overview permanent; | ||
| rewrite ^/sdk/js/?$ /sdk/js/docs/overview permanent; | ||
| rewrite ^/sdk/python/?$ /sdk/python/docs/overview permanent; | ||
| rewrite ^/cli/?$ /cli/docs permanent; |
There was a problem hiding this comment.
Rewrite rules break LLM markdown serving for root paths
Medium Severity
The new rewrite rules with permanent flag execute during nginx's rewrite phase before location matching. This means requests to /sdk/js, /sdk/python, /api/client/js, /api/client/python, and /cli will receive 301 redirects before the location = blocks can check $serve_markdown and serve llms.txt content. LLM clients requesting markdown content at these root paths will be redirected to docs pages instead of receiving the expected LLM text files.
|
To fix the buld you will need to adjust the tests for the accept header, since they check the pages you are now redirecting. It's directly in the workflow: https://github.com/apify/apify-docs/actions/runs/21593890821/workflow?pr=2213#L66 (I can try to fix this myself if it feels too scary) |
|
I'll try to figure it out with help of claude if not then I'll ping for some help, thanks! |
|
Preview for this PR was built for commit |
4 participants
Note
Low Risk
Only changes URL rewrite/redirect behavior for a handful of docs entry routes; risk is limited to potential misrouting or caching effects from switching to
permanentredirects.Overview
Updates
nginx.confrewrite rules to replace trailing-slash normalization redirects for/api/client/*,/sdk/*, and/cliwith permanent redirects that send those root paths directly to the appropriate docs landing pages (e.g.,/api/client/js→/api/client/js/docs,/sdk/js→/sdk/js/docs/overview).Written by Cursor Bugbot for commit edd694a. Configure here.